SA|ITP MAY 2025|INNOCENT NIWATWINE| Structuring and Data Testing| Sprint 3 #635
Conversation
InnocentNiwatwine
changed the title
InnocentNiwatwine
added
the
Needs Review
LonMcGregor
added
Review in progress
| if (angle === 180) return "Straight angle"; | ||
| if (angle > 180 && angle < 360) return "Reflex angle"; | ||
| else if (angle > 180 && angle < 360) return "Reflex angle"; | ||
| } |
There was a problem hiding this comment.
Do you need to have the same condition twice here?
There was a problem hiding this comment.
You are right i don't need to have the same condition twice because it is kind of duplication since the first condition already returns if that condition is true.I will proceed to remove ''else if'', thank you
| } else if (numerator >= denominator) { | ||
| return false; | ||
| } else if (numerator === 1) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Does this solution work for negative improper fractions, like -7/4?
There was a problem hiding this comment.
It could not because i found out what i did only checks numerator>=denominator and it didnt include the negative improper fractions ,i have tried to correct it, Thank you
| @@ -1,5 +1,7 @@ | |||
| function isProperFraction(numerator, denominator) { | |||
| if (numerator < denominator) return true; | |||
| // add your completed function from key-implement here | |||
| if (numerator >= denominator) return false; | |||
| // add your completed function from key-implement here | |||
There was a problem hiding this comment.
Here you are checking a condition which will give a true or false value, and you are then returning the same true or false value. Can you see a way to rewrite this that would simplify the function?
LonMcGregor
added
Reviewed
There was a problem hiding this comment.
What you've changed here doesn't really solve the problem with the fraction checking. Remember to make sure you run your tests when making changes, as well written tests will catch any problems.
The goal with the fraction checking is that
- When the numerator is smaller than the denominator (regardless of negatives) this is proper
- In any other case it is not proper
Can you think of a javascript function you could use to help you easily handle cases where there are negative numbers
No description provided.